Make the ResponseAccumulator Sendable #838
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: The response accumulator is a delegate which must be sendable as it's passed across isolation domains. Modifications: - Make delegates have a sendable requirement - Make the response accumulator sendable Result: Delegates, and the response accumulator, are sendable
Lukasa
reviewed
Apr 30, 2025
| if self.requestMethod != .HEAD, | ||
| let contentLength = head.headers.first(name: "Content-Length"), | ||
| let announcedBodySize = Int(contentLength), | ||
| announcedBodySize > self.maxBodySize |
There was a problem hiding this comment.
Can I suggest that we pull this computation out of the lock?
| @@ -894,30 +910,35 @@ extension HTTPClient { | |||
| /// | |||
| /// Will be created by the library and could be used for obtaining | |||
| /// `EventLoopFuture<Response>` of the execution or cancellation of the execution. | |||
| public final class Task<Response> { | |||
| @preconcurrency | |||
| public final class Task<Response: Sendable> { | |||
There was a problem hiding this comment.
Is the unchecked Sendable still needed for this? Can it be checked?
| } | ||
| } | ||
|
|
||
| private var _isCancelled: Bool = false | ||
| private var _taskDelegate: HTTPClientTaskDelegate? | ||
| private let lock = NIOLock() | ||
| private let makeOrGetFileIOThreadPool: () -> NIOThreadPool |
There was a problem hiding this comment.
Looks like this needs an @Sendable.
| @@ -894,30 +910,35 @@ extension HTTPClient { | |||
| /// | |||
| /// Will be created by the library and could be used for obtaining | |||
| /// `EventLoopFuture<Response>` of the execution or cancellation of the execution. | |||
| public final class Task<Response> { | |||
| @preconcurrency | |||
| public final class Task<Response: Sendable> { | |||
There was a problem hiding this comment.
Also, how sure are we that this constraint is needed?
Lukasa
approved these changes
Apr 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
The response accumulator is a delegate which must be sendable as it's passed across isolation domains.
Modifications:
Result:
Delegates, and the response accumulator, are sendable